Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(simple_object_merger)!: fix namespace and directory structure #7700

Conversation

technolojin
Copy link
Contributor

Description

This PR puts headers in the autoware namespace.
Part of: autowarefoundation/autoware#4569

Additional works

  1. Align directory structure to follow the coding guidelines.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Not applicable.

Refactor the library and node names in the simple_object_merger package to follow the autoware namespace convention. This includes renaming the library from simple_object_merger_node_component to autoware_simple_object_merger and the node from simple_object_merger_node to autoware_simple_object_merger_node.

Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jun 26, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin marked this pull request as ready for review June 26, 2024 04:14
@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (507e3f4) to head (f6bf208).
Report is 153 commits behind head on main.

Files Patch % Lines
...le_object_merger/src/simple_object_merger_node.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #7700       +/-   ##
==========================================
- Coverage   14.84%   0.00%   -14.85%     
==========================================
  Files        1999      33     -1966     
  Lines      139163    1822   -137341     
  Branches    43716      77    -43639     
==========================================
- Hits        20661       0    -20661     
+ Misses      95731    1822    -93909     
+ Partials    22771       0    -22771     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@scepter914 scepter914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(Note: without checking acting, after integrating with other PRs and checking acting this PR can be merged)

@technolojin technolojin merged commit fcfa6d0 into autowarefoundation:main Jun 27, 2024
38 of 41 checks passed
mitukou1109 pushed a commit to mitukou1109/autoware.universe that referenced this pull request Jul 2, 2024
autowarefoundation#7700)

* refactor(simple_object_merger): refactor library and node names

Refactor the library and node names in the simple_object_merger package to follow the autoware namespace convention. This includes renaming the library from simple_object_merger_node_component to autoware_simple_object_merger and the node from simple_object_merger_node to autoware_simple_object_merger_node.

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: fix the node name

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: rename simple_object_merger library and node to follow autoware namespace convention

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: move node header to src

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
autowarefoundation#7700)

* refactor(simple_object_merger): refactor library and node names

Refactor the library and node names in the simple_object_merger package to follow the autoware namespace convention. This includes renaming the library from simple_object_merger_node_component to autoware_simple_object_merger and the node from simple_object_merger_node to autoware_simple_object_merger_node.

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: fix the node name

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: rename simple_object_merger library and node to follow autoware namespace convention

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: move node header to src

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: palas21 <[email protected]>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
autowarefoundation#7700)

* refactor(simple_object_merger): refactor library and node names

Refactor the library and node names in the simple_object_merger package to follow the autoware namespace convention. This includes renaming the library from simple_object_merger_node_component to autoware_simple_object_merger and the node from simple_object_merger_node to autoware_simple_object_merger_node.

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: fix the node name

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: rename simple_object_merger library and node to follow autoware namespace convention

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: move node header to src

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
#7700)

* refactor(simple_object_merger): refactor library and node names

Refactor the library and node names in the simple_object_merger package to follow the autoware namespace convention. This includes renaming the library from simple_object_merger_node_component to autoware_simple_object_merger and the node from simple_object_merger_node to autoware_simple_object_merger_node.

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: fix the node name

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: rename simple_object_merger library and node to follow autoware namespace convention

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: move node header to src

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
@technolojin technolojin deleted the refactor/namespace_simple_object_merger branch July 26, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants