-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(simple_object_merger)!: fix namespace and directory structure #7700
refactor(simple_object_merger)!: fix namespace and directory structure #7700
Conversation
Refactor the library and node names in the simple_object_merger package to follow the autoware namespace convention. This includes renaming the library from simple_object_merger_node_component to autoware_simple_object_merger and the node from simple_object_merger_node to autoware_simple_object_merger_node. Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
…ware namespace convention Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7700 +/- ##
==========================================
- Coverage 14.84% 0.00% -14.85%
==========================================
Files 1999 33 -1966
Lines 139163 1822 -137341
Branches 43716 77 -43639
==========================================
- Hits 20661 0 -20661
+ Misses 95731 1822 -93909
+ Partials 22771 0 -22771
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(Note: without checking acting, after integrating with other PRs and checking acting this PR can be merged)
autowarefoundation#7700) * refactor(simple_object_merger): refactor library and node names Refactor the library and node names in the simple_object_merger package to follow the autoware namespace convention. This includes renaming the library from simple_object_merger_node_component to autoware_simple_object_merger and the node from simple_object_merger_node to autoware_simple_object_merger_node. Signed-off-by: Taekjin LEE <[email protected]> * refactor: fix the node name Signed-off-by: Taekjin LEE <[email protected]> * refactor: rename simple_object_merger library and node to follow autoware namespace convention Signed-off-by: Taekjin LEE <[email protected]> * refactor: move node header to src Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]>
autowarefoundation#7700) * refactor(simple_object_merger): refactor library and node names Refactor the library and node names in the simple_object_merger package to follow the autoware namespace convention. This includes renaming the library from simple_object_merger_node_component to autoware_simple_object_merger and the node from simple_object_merger_node to autoware_simple_object_merger_node. Signed-off-by: Taekjin LEE <[email protected]> * refactor: fix the node name Signed-off-by: Taekjin LEE <[email protected]> * refactor: rename simple_object_merger library and node to follow autoware namespace convention Signed-off-by: Taekjin LEE <[email protected]> * refactor: move node header to src Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]> Signed-off-by: palas21 <[email protected]>
autowarefoundation#7700) * refactor(simple_object_merger): refactor library and node names Refactor the library and node names in the simple_object_merger package to follow the autoware namespace convention. This includes renaming the library from simple_object_merger_node_component to autoware_simple_object_merger and the node from simple_object_merger_node to autoware_simple_object_merger_node. Signed-off-by: Taekjin LEE <[email protected]> * refactor: fix the node name Signed-off-by: Taekjin LEE <[email protected]> * refactor: rename simple_object_merger library and node to follow autoware namespace convention Signed-off-by: Taekjin LEE <[email protected]> * refactor: move node header to src Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]>
#7700) * refactor(simple_object_merger): refactor library and node names Refactor the library and node names in the simple_object_merger package to follow the autoware namespace convention. This includes renaming the library from simple_object_merger_node_component to autoware_simple_object_merger and the node from simple_object_merger_node to autoware_simple_object_merger_node. Signed-off-by: Taekjin LEE <[email protected]> * refactor: fix the node name Signed-off-by: Taekjin LEE <[email protected]> * refactor: rename simple_object_merger library and node to follow autoware namespace convention Signed-off-by: Taekjin LEE <[email protected]> * refactor: move node header to src Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]>
Description
This PR puts headers in the
autoware
namespace.Part of: autowarefoundation/autoware#4569
Additional works
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Not applicable.